Here we had a question when we implement the Rosetta API. Can we add the Secp256r1 Curve (which is Neo using) to the CurveType in the signature? Here is the original file:
In you docs, you mention that Neo uses a “special secp256r1-standard elliptic curve”. However, this looks to us like the “standard secp256r1 elliptic curve” (commonly referred to as
NIST-P256). Is that correct?
Can we add the Secp256r1 Curve (which is Neo using) to the CurveType in the signature?
Congrats @steven This is the first
CurveType/SignatureType request!! The process for adding support for a new
SignatureType is as follows:
- Create a PR in
CurveTypemodel. Make sure to clearly define the canonical format of this curve (in this case, it should just be a copy and paste of the
- Once the specification update is released, add the new
asserterpackage. This package is used by many integrators to communicate with Rosetta implementations.
[Optional, but highly encouraged] Add support for the
keyspackage. This package is used by the
rosetta-clito perform automatic Construction API testing.
We are actively working on ways to support more signing libraries (in different languages) during automated testing but have yet to formalize/release anything.
Thanks for your detailed response!! Sure, We will do that.
Here’s an example of PR that adds a
SignatureType (may help!):